Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli solidity framework option #801

Closed
wants to merge 3 commits into from
Closed

Cli solidity framework option #801

wants to merge 3 commits into from

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Apr 5, 2024

Description

Solidity framework option from CLI. It could be a discussion but I think in this case it's easier to discuss when you already see the code. Feel free to add suggestions 🙂

usage examples (dev):

yarn cli --solidity-framework hardhat
yarn cli --solidity-framework=foundry
yarn cli -f none

In case of several solidity framework flags, last will be taken

Other options I thought about.

  1. --hardhat, --foundry and --skip-solidity-framework. Looks bad. Need to check if two or more flags chosen and add additional ifs to fix/throw error
  2. --extensions flag. It's not clear how to add let's say none, and how to mix it with other extensions non-related to solidity frameworks

Not sure how it will work with nested extensions but I think it's not a problem to update recurring logic if needed.

Also in this pr I added error if both --install and --skip-install chosen

Thanks!

Additional Information

@rin-st rin-st marked this pull request as draft April 5, 2024 20:09
@damianmarti
Copy link
Member

I like it!

I think it's good to be able to set the solidity framework to use directly from the command line.

@technophile-04
Copy link
Collaborator

@rin-st could you please port this PR to create-eth repo? This is will also open the doors for scaffold-eth#23

@rin-st
Copy link
Member Author

rin-st commented Jun 18, 2024

closing due to scaffold-eth#58

@rin-st rin-st closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants